Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect Transform2D docs #98442

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix incorrect Transform2D docs #98442

merged 1 commit into from
Oct 23, 2024

Conversation

tetrapod00
Copy link
Contributor

Fixes godotengine/godot-docs#10133. The y vector of a Transform2d was incorrectly described as pointing up.

Is this the right wording for a fix? Does the y vector of a Transform2D conceptually point "up", even though the y vector matches Vector2.DOWN?

Console output from test on a Node2D:

transform == Transform2D.IDENTITY: true
Vector2.UP: (0, -1)
transform.y: (0, 1)

@tetrapod00
Fix incorrect Transform2D docs
9cf6cb0 
The y vector of a transform 2d was incorrectly described as pointing up.
@tetrapod00 tetrapod00 requested a review from a team as a code owner October 23, 2024 00:21
@Chaosus Chaosus added this to the 4.4 milestone Oct 23, 2024
Mickeon
Mickeon approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is my oversight.

@Mickeon Mickeon added cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release bug and removed enhancement labels Oct 23, 2024
@clayjohn clayjohn merged commit e25776e into godotengine:master Oct 23, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@tetrapod00 tetrapod00 deleted the transform-2d-docs-fix branch October 24, 2024 03:02
@Spartan322 Spartan322 mentioned this pull request Oct 31, 2024
Merged
@jss2a98aj jss2a98aj mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation topic:2d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Incorrect documentation for Transform2D
4 participants
@tetrapod00 @clayjohn @Mickeon @Chaosus